-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Verification] Adds type and value assertion for assigner tests #1065
Merged
yhassanzadeh13
merged 14 commits into
master
from
yahya/5420-type-and-value-assertion-assigner-engine
Aug 6, 2021
Merged
[Verification] Adds type and value assertion for assigner tests #1065
yhassanzadeh13
merged 14 commits into
master
from
yahya/5420-type-and-value-assertion-assigner-engine
Aug 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhassanzadeh13
requested review from
zhangchiqing and
jordanschalm
and removed request for
ramtinms
July 30, 2021 20:59
Codecov Report
@@ Coverage Diff @@
## master #1065 +/- ##
==========================================
- Coverage 53.34% 53.32% -0.02%
==========================================
Files 318 318
Lines 21559 21559
==========================================
- Hits 11501 11497 -4
- Misses 8486 8491 +5
+ Partials 1572 1571 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jordanschalm
approved these changes
Aug 4, 2021
Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
zhangchiqing
approved these changes
Aug 5, 2021
yhassanzadeh13
deleted the
yahya/5420-type-and-value-assertion-assigner-engine
branch
August 6, 2021 00:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a comment of @zhangchiqing on an earlier PR for the
assigner
engine ofverification
node.