Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Verification] Adds type and value assertion for assigner tests #1065

Merged

Conversation

yhassanzadeh13
Copy link
Contributor

This PR addresses a comment of @zhangchiqing on an earlier PR for the assigner engine of verification node.

... update the assertion on the chunkQueues.StoreChunkLocator call, to assert the arguments passed into the calls.

@yhassanzadeh13 yhassanzadeh13 requested review from zhangchiqing and jordanschalm and removed request for ramtinms July 30, 2021 20:59
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2021

Codecov Report

Merging #1065 (ee356ea) into master (fd4a4bb) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
- Coverage   53.34%   53.32%   -0.02%     
==========================================
  Files         318      318              
  Lines       21559    21559              
==========================================
- Hits        11501    11497       -4     
- Misses       8486     8491       +5     
+ Partials     1572     1571       -1     
Flag Coverage Δ
unittests 53.32% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sus/approvals/assignment_collector_statemachine.go 42.30% <0.00%> (-4.81%) ⬇️
cmd/util/ledger/migrations/storage_v4.go 42.16% <0.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd4a4bb...ee356ea. Read the comment docs.

engine/verification/assigner/engine_test.go Outdated Show resolved Hide resolved
@yhassanzadeh13 yhassanzadeh13 merged commit 76f73ec into master Aug 6, 2021
@yhassanzadeh13 yhassanzadeh13 deleted the yahya/5420-type-and-value-assertion-assigner-engine branch August 6, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants