Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Integration] Fixes loader chain ID #1084

Merged
merged 3 commits into from
Aug 4, 2021
Merged

Conversation

yhassanzadeh13
Copy link
Contributor

Fixes the chain ID of the loader as the mitigation to the following crash-loop on benchnet1:

calling get account for service account client: rpc error: code = InvalidArgument desc = address 8c5303eaa26202d6 is invalid for chain flow-benchnet"
Jul 30 23:12:39 loader-001 systemd[1]: flow-loader.service: Main process exited, code=exited, status=1/FAILURE

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2021

Codecov Report

Merging #1084 (c426663) into master (c030509) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1084      +/-   ##
==========================================
+ Coverage   53.32%   53.36%   +0.04%     
==========================================
  Files         318      318              
  Lines       21559    21559              
==========================================
+ Hits        11496    11505       +9     
+ Misses       8492     8480      -12     
- Partials     1571     1574       +3     
Flag Coverage Δ
unittests 53.36% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
engine/common/synchronization/engine.go 64.01% <0.00%> (ø)
cmd/util/ledger/migrations/storage_v4.go 42.16% <0.00%> (+0.60%) ⬆️
...sus/approvals/assignment_collector_statemachine.go 50.00% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c030509...c426663. Read the comment docs.

@yhassanzadeh13 yhassanzadeh13 merged commit fd4a4bb into master Aug 4, 2021
@yhassanzadeh13 yhassanzadeh13 deleted the yahya/fix-loader-chain-id branch August 4, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants