Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bootstrap key Machine Account Key bug #1092

Merged
merged 5 commits into from
Aug 7, 2021

Conversation

danuio
Copy link
Contributor

@danuio danuio commented Aug 6, 2021

  • Fixes a bug where the machine account key is created for all nodes
  • Machine account key is now only created for consensus and collection nodes

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2021

Codecov Report

Merging #1092 (06aeaff) into master (4dde0e3) will increase coverage by 0.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1092      +/-   ##
==========================================
+ Coverage   53.14%   53.15%   +0.01%     
==========================================
  Files         321      321              
  Lines       21725    21730       +5     
==========================================
+ Hits        11545    11551       +6     
+ Misses       8614     8610       -4     
- Partials     1566     1569       +3     
Flag Coverage Δ
unittests 53.15% <57.14%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/bootstrap/cmd/key.go 71.01% <57.14%> (-0.87%) ⬇️
...sus/approvals/assignment_collector_statemachine.go 45.19% <0.00%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dde0e3...06aeaff. Read the comment docs.

@danuio danuio merged commit 5e6ef3d into master Aug 7, 2021
@danuio danuio deleted the danu/bootstrap-cmd-machine-account-bug branch August 7, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants