Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Deploy Epoch helper utility #1113

Merged
merged 17 commits into from
Aug 26, 2021
Merged

Fix Deploy Epoch helper utility #1113

merged 17 commits into from
Aug 26, 2021

Conversation

jordanschalm
Copy link
Member

@jordanschalm jordanschalm commented Aug 10, 2021

This PR fixes some problems with the util epochs deploy-tx-args helper command:

  • Moves the contract code into a variable defined within the transaction text, rather than a transaction argument
  • Fixes a transaction argument type

⚠️ Merge #1171 first

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2021

Codecov Report

Merging #1113 (26c1b10) into master (814b004) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1113      +/-   ##
==========================================
- Coverage   55.71%   55.69%   -0.03%     
==========================================
  Files         482      482              
  Lines       29644    29663      +19     
==========================================
+ Hits        16517    16520       +3     
- Misses      10864    10881      +17     
+ Partials     2263     2262       -1     
Flag Coverage Δ
unittests 55.69% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/util/cmd/epochs/cmd/deploy.go 7.81% <0.00%> (-1.37%) ⬇️
engine/common/synchronization/engine.go 67.20% <0.00%> (ø)
cmd/util/ledger/migrations/storage_v4.go 42.16% <0.00%> (+0.60%) ⬆️
...sus/approvals/assignment_collector_statemachine.go 51.92% <0.00%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 814b004...26c1b10. Read the comment docs.

@jordanschalm
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 26, 2021

@bors bors bot merged commit a37e991 into master Aug 26, 2021
@bors bors bot deleted the jordan/deploy-epoch-args-fix branch August 26, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants