skip connecting to invalid identities in the identity table and log error instead of fatal #1138
Conversation
…rror instead of fatal
Codecov Report
@@ Coverage Diff @@
## master #1138 +/- ##
==========================================
+ Coverage 55.67% 55.71% +0.03%
==========================================
Files 481 481
Lines 29391 29387 -4
==========================================
+ Hits 16364 16373 +9
+ Misses 10797 10781 -16
- Partials 2230 2233 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| return | ||
| if err != nil { | ||
| // one of more identities in the identity table could not be connected to | ||
| pm.logger.Error().Err(err).Msg("failed to connect to one or more peers") |
There was a problem hiding this comment.
It seems this can only be an NewUnconvertableIdentitiesError in our implementation. Could we unpack this case and thereby maybe get a more usable error message?
There was a problem hiding this comment.
so UnconvertableIdentitiesError is logged as multiple individual errors (multi-error) which will list out the Identity and the error reason.
Will that suffice?
|
@vishalchangrani you could use bors to merge this |
|
bors merge |
1138: skip connecting to invalid identities in the identity table and log error instead of fatal r=vishalchangrani a=vishalchangrani Found one more place where it was `log.fatal` on a bad identity. 1163: [network] Check the OriginID of a libp2p message corresponds to its authenticated source r=huitseeker a=huitseeker Contributes to #1115. Follow-up of #1129. Edit: there was no problem with the integration tests, 🤦 However, TestMiddlewareTestSuit/TestUnsubscribe is still flaky based on the delay in the last step (sending the message once a mesh has formed). But it is problematic on master, see [[1]](https://github.com/onflow/flow-go/runs/3357056741) [[2]](https://github.com/onflow/flow-go/runs/3356508175), so this is not relevant to this PR per se. Co-authored-by: Vishal <1117327+vishalchangrani@users.noreply.github.com> Co-authored-by: François Garillot <francois.garillot@dapperlabs.com>
|
Build failed (retrying...): |
Found one more place where it was
log.fatalon a bad identity.