[DKG] improve logging #1162
[DKG] improve logging #1162
Conversation
| b.log.Warn().Msgf("DKG broadcast number %d", b.broadcasts+1) | ||
| b.log.Warn().Msgf("DKG broadcast number %d with header %d", b.broadcasts+1, data[0]) | ||
| } else { | ||
| b.log.Info().Msgf("DKG message broadcast with header %d", data[0]) |
There was a problem hiding this comment.
Aren't we rather indicating that we're entering a DKG message broadcast phase?
There was a problem hiding this comment.
There are already logs for finishing a DKG phase and entering a new one. Here I'm adding a more granular log for every broadcast. It helps me understand what is happening in unhappy paths.
There was a problem hiding this comment.
OK, maybe "DKG initial message broadcast" makes sense in the message then?
There was a problem hiding this comment.
The log here is made for every call to broadcast, and not necessarily for the initial broadcast. This includes the initial message, the complaint(s) and their answer(s).
| b.log.Warn().Msgf("DKG broadcast number %d", b.broadcasts+1) | ||
| b.log.Warn().Msgf("DKG broadcast number %d with header %d", b.broadcasts+1, data[0]) | ||
| } else { | ||
| b.log.Info().Msgf("DKG message broadcast with header %d", data[0]) |
There was a problem hiding this comment.
OK, maybe "DKG initial message broadcast" makes sense in the message then?
|
This is probably a good PR to try using bors with 😁 |
|
bors merge |
|
Canceled. |
|
bors merge |
Improve logging for DKG broadcasted messages.