New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FVM] let cadence runtime record generic traces #1189
[FVM] let cadence runtime record generic traces #1189
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1189 +/- ##
==========================================
+ Coverage 54.85% 54.98% +0.12%
==========================================
Files 501 501
Lines 31761 31713 -48
==========================================
+ Hits 17424 17437 +13
+ Misses 11971 11919 -52
+ Partials 2366 2357 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…hub.com:onflow/flow-go into ramtin/add-generic-tracing-to-cadence-interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Code looks cleaner with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR unlocks cadence runtime to capture generic traces instead of a fixed set which is captured alongside metrics.