Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FVM] let cadence runtime record generic traces #1189

Merged
merged 10 commits into from Sep 16, 2021

Conversation

ramtinms
Copy link
Member

@ramtinms ramtinms commented Aug 23, 2021

This PR unlocks cadence runtime to capture generic traces instead of a fixed set which is captured alongside metrics.

fvm/scriptEnv.go Outdated Show resolved Hide resolved
fvm/scriptEnv.go Outdated Show resolved Hide resolved
fvm/scriptEnv.go Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2021

Codecov Report

Merging #1189 (5e57d61) into master (4ddc17d) will increase coverage by 0.12%.
The diff coverage is 43.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1189      +/-   ##
==========================================
+ Coverage   54.85%   54.98%   +0.12%     
==========================================
  Files         501      501              
  Lines       31761    31713      -48     
==========================================
+ Hits        17424    17437      +13     
+ Misses      11971    11919      -52     
+ Partials     2366     2357       -9     
Flag Coverage Δ
unittests 54.98% <43.33%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
fvm/scriptEnv.go 40.30% <40.00%> (+4.42%) ⬆️
fvm/transactionEnv.go 48.81% <46.66%> (+3.82%) ⬆️
engine/collection/synchronization/engine.go 62.90% <0.00%> (-1.08%) ⬇️
...ngine/common/synchronization/finalized_snapshot.go 72.91% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ddc17d...5e57d61. Read the comment docs.

@ramtinms ramtinms changed the title [FVM] let cadence record generic traces [FVM] let cadence runtime records generic traces Aug 23, 2021
@ramtinms ramtinms changed the title [FVM] let cadence runtime records generic traces [FVM] let cadence runtime record generic traces Aug 23, 2021
@ramtinms ramtinms requested a review from m4ksio August 23, 2021 22:34
Copy link
Contributor

@janezpodhostnik janezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Code looks cleaner with this.

module/trace/constants.go Show resolved Hide resolved
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

fvm/scriptEnv.go Outdated Show resolved Hide resolved
fvm/transactionEnv.go Outdated Show resolved Hide resolved
@ramtinms ramtinms merged commit 698c774 into master Sep 16, 2021
@ramtinms ramtinms deleted the ramtin/add-generic-tracing-to-cadence-interface branch September 16, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants