Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Update check_go_version #1212

Merged
merged 1 commit into from
Aug 27, 2021
Merged

[build] Update check_go_version #1212

merged 1 commit into from
Aug 27, 2021

Conversation

huitseeker
Copy link
Contributor

  • we support go 1.15+
  • go 1.17 is out

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2021

Codecov Report

Merging #1212 (c6b76bc) into master (8c02466) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1212   +/-   ##
=======================================
  Coverage   55.81%   55.81%           
=======================================
  Files         484      484           
  Lines       29769    29769           
=======================================
+ Hits        16615    16617    +2     
+ Misses      10890    10886    -4     
- Partials     2264     2266    +2     
Flag Coverage Δ
unittests 55.81% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/util/ledger/migrations/storage_v4.go 41.56% <0.00%> (-0.61%) ⬇️
...sus/approvals/assignment_collector_statemachine.go 50.00% <0.00%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c02466...c6b76bc. Read the comment docs.

Makefile Show resolved Hide resolved
- we support go 1.15+
- go 1.17 is out
.PHONY: check-go-version
check-go-version:
go version | grep '1.1[3-6]'
go version | grep '1.1[5-9]'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

up to 9?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.e. we shouldn't have to revisit this upper bound until Feb 2023

@huitseeker
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 27, 2021

@bors bors bot merged commit 013a251 into onflow:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants