-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Update check_go_version #1212
Conversation
huitseeker
commented
Aug 26, 2021
- we support go 1.15+
- go 1.17 is out
Codecov Report
@@ Coverage Diff @@
## master #1212 +/- ##
=======================================
Coverage 55.81% 55.81%
=======================================
Files 484 484
Lines 29769 29769
=======================================
+ Hits 16615 16617 +2
+ Misses 10890 10886 -4
- Partials 2264 2266 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
- we support go 1.15+ - go 1.17 is out
.PHONY: check-go-version | ||
check-go-version: | ||
go version | grep '1.1[3-6]' | ||
go version | grep '1.1[5-9]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
up to 9?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i.e. we shouldn't have to revisit this upper bound until Feb 2023
bors merge |