Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct type in NewThresholdSigner #1217

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

jordanschalm
Copy link
Member

Previously, this was inconsistent with the relic version of the file, so that builds not using relic importing this package failed to compile.

@codecov-commenter
Copy link

Codecov Report

Merging #1217 (79b2732) into master (a91c69d) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1217      +/-   ##
==========================================
- Coverage   55.80%   55.79%   -0.02%     
==========================================
  Files         484      484              
  Lines       29770    29770              
==========================================
- Hits        16612    16609       -3     
- Misses      10894    10897       +3     
  Partials     2264     2264              
Flag Coverage Δ
unittests 55.79% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
engine/common/synchronization/engine.go 67.20% <0.00%> (-1.08%) ⬇️
cmd/util/ledger/migrations/storage_v4.go 41.56% <0.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a91c69d...79b2732. Read the comment docs.

@jordanschalm
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 30, 2021

@bors bors bot merged commit be8fae8 into master Aug 30, 2021
@bors bors bot deleted the jordan/hf/fix-non-relic-threshold-signer-constructor branch August 30, 2021 16:08
@vishalchangrani
Copy link
Contributor

Will this target in the Makefile - docker-build-bootstrap-transit still work or does the --target production-transit-nocgo flag needs to be removed?

@jordanschalm
Copy link
Member Author

Will this target in the Makefile - docker-build-bootstrap-transit still work

It works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants