Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that --machine-account-address flag is valid Flow address #1226

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

jordanschalm
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2021

Codecov Report

Merging #1226 (5faf3eb) into master (be8fae8) will increase coverage by 0.01%.
The diff coverage is 57.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1226      +/-   ##
==========================================
+ Coverage   55.81%   55.83%   +0.01%     
==========================================
  Files         484      484              
  Lines       29770    29788      +18     
==========================================
+ Hits        16615    16631      +16     
+ Misses      10890    10889       -1     
- Partials     2265     2268       +3     
Flag Coverage Δ
unittests 55.83% <57.89%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/bootstrap/cmd/machine_account.go 62.74% <55.55%> (-3.93%) ⬇️
cmd/bootstrap/cmd/keys.go 59.15% <100.00%> (ø)
cmd/util/ledger/migrations/storage_v4.go 41.56% <0.00%> (-0.61%) ⬇️
...sus/approvals/assignment_collector_statemachine.go 53.84% <0.00%> (+6.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be8fae8...5faf3eb. Read the comment docs.

@jordanschalm jordanschalm merged commit 8f728bd into master Aug 30, 2021
@jordanschalm jordanschalm deleted the jordan/hf/validate-machine-account-addr-input branch August 30, 2021 23:30
jordanschalm added a commit to onflow/flow that referenced this pull request Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants