Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block final state commitment #1239

Merged
merged 3 commits into from
Sep 3, 2021
Merged

Conversation

m4ksio
Copy link
Contributor

@m4ksio m4ksio commented Sep 2, 2021

Ported from v0.21

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021

Codecov Report

Merging #1239 (6e20295) into master (cbf525a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1239      +/-   ##
==========================================
- Coverage   56.24%   56.22%   -0.02%     
==========================================
  Files         495      495              
  Lines       30124    30125       +1     
==========================================
- Hits        16942    16938       -4     
- Misses      10883    10887       +4     
- Partials     2299     2300       +1     
Flag Coverage Δ
unittests 56.22% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/execution/computation/computer/uploader/model.go 64.70% <100.00%> (+2.20%) ⬆️
...ngine/common/synchronization/finalized_snapshot.go 68.75% <0.00%> (-4.17%) ⬇️
...sus/approvals/assignment_collector_statemachine.go 45.19% <0.00%> (-1.93%) ⬇️
cmd/util/ledger/migrations/storage_v4.go 41.56% <0.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbf525a...6e20295. Read the comment docs.

Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the port (original in #1235)

Copy link
Contributor

@synzhu synzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@m4ksio
Copy link
Contributor Author

m4ksio commented Sep 3, 2021

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 3, 2021

@bors bors bot merged commit 0485ef3 into master Sep 3, 2021
@bors bors bot deleted the m4ksio/port-en-uploader-extension branch September 3, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants