Update to Cadence v0.19.0 #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upgrade/1629742154/bastian/check-invocation-receiver
…upgrade/1629742154/bastian/check-invocation-receiver
…n-receiver' of github.com:onflow/flow-go into auto-cadence-upgrade/1629902958/feature/container-static-types
…n-receiver' of github.com:onflow/flow-go into auto-cadence-upgrade/1629902958/feature/container-static-types
SupunS
force-pushed
the
supun/cadence-v0.19.0
branch
from
eb21b24
to
b04f361
Compare
… into supun/cadence-v0.19.0
… into supun/cadence-v0.19.0
SupunS
requested review from
janezpodhostnik,
m4ksio and
ramtinms
as code owners
SupunS
commented
Sep 8, 2021
Comment on lines
-142
to
-144
| if version <= 3 { | ||
| decodeFunction = interpreter.DecodeValueV3 | ||
| } |
There was a problem hiding this comment.
Version 3 is no longer available/possible.
| "github.com/onflow/flow-go/ledger" | ||
| ) | ||
|
|
||
| func TestStorageFormatV4Migration(t *testing.T) { |
There was a problem hiding this comment.
These tests are also no longer valid. storage_v4.go file was left only for reference.
Kay-Zee
approved these changes
Sep 8, 2021
| @@ -47,7 +47,7 @@ func TestBootstrapLedger(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestBootstrapLedger_ZeroTokenSupply(t *testing.T) { | |||
| expectedStateCommitmentBytes, _ := hex.DecodeString("96af74917f39a5fc689260e5066c9ab19ff93c27a555ef27f3e95e04e9d12856") | |||
| expectedStateCommitmentBytes, _ := hex.DecodeString("4951e30c1c7aa71cb01ce0d744e45c357a6456f10047663da1af997a384b7d51") | |||
There was a problem hiding this comment.
NOTE: These are changed on purpose, as the storage layer is slightly altered here.
| @@ -19,7 +19,7 @@ import ( | |||
| const ServiceAccountPrivateKeyHex = "e3a08ae3d0461cfed6d6f49bfc25fa899351c39d1bd21fdba8c87595b6c49bb4cc430201" | |||
|
|
|||
| // Pre-calculated state commitment with root account with the above private key | |||
| const GenesisStateCommitmentHex = "2fac1ddd9cdf8d036e97fed716f70183ce75b944eb1fde7cc97cb0a7ebcb4959" | |||
| const GenesisStateCommitmentHex = "d199da82127e0da6304191bb89296683cfafa65fe5cd6d7a91d743ee2e1b95d0" | |||
There was a problem hiding this comment.
NOTE: These are changed on purpose, as the storage layer is slightly altered here.
Codecov Report
@@ Coverage Diff @@
## master #1265 +/- ##
==========================================
- Coverage 56.22% 56.02% -0.21%
==========================================
Files 497 497
Lines 30388 30386 -2
==========================================
- Hits 17087 17025 -62
- Misses 10975 11051 +76
+ Partials 2326 2310 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
As this is mainly a version bump, will merge, inorder include in release |
bors bot
added a commit
that referenced
this pull request
Sep 8, 2021
1264: Add storage migration to inject static types to cadence values r=Kay-Zee a=SupunS ## Description: This migration adds static types info to cadence values with missing type info. This is required for onflow/cadence#870 **Depends on:** #1265 ## Steps to run: - Build the binary with: ``` GOOS=linux GOARCH=amd64 go build ./cmd/util ``` - Run with the following command. Here `<checkpoint-dir>` is the directory where the checkpoint file is located. `<output-dir>` is the directory where outputs will be generated (assumes `<output-dir>` exists). ``` ./util execution-state-extract --execution-state-dir <checkpoint-dir> --output-dir <output-dir> ``` - To remove broken contracts and clean up the storage, add ` --cleanup-storage` flag. e.g: ``` ./util execution-state-extract --execution-state-dir <checkpoint-dir> --output-dir <output-dir> --cleanup-storage ``` Co-authored-by: Bastian Müller <bastian@axiomzen.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the Cadence version to v0.19.0
Also includes unit test fixes @janezpodhostnik did in #1199
NOTE: I noticed a few intermittent test failures. Retriggering the CI changes the status of these test failures (sometimes unit tests and other times its integration tests). Not sure if it's a CI issue (caching maybe?), an issue in the test case, or an actual bug in the code.