[module] Suggestions for #1275 #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possibly superfluous: - type assertions to be able to use a function on Context instances that are actually IrrecoverableSignalerContext, Possibly missing: - do we need to demo more in the component. E.g. RunComponent may demo cleanup, etc?
huitseeker
force-pushed
the
smnzhu/error-handling
branch
from
af746b5
to
afb4e6d
Compare
peterargue
reviewed
Sep 17, 2021
synzhu
reviewed
Sep 18, 2021
3 tasks
synzhu
reviewed
Sep 18, 2021
synzhu
reviewed
Sep 20, 2021
huitseeker
force-pushed
the
smnzhu/error-handling
branch
from
26ad838
to
4c947a1
Compare
synzhu
approved these changes
Sep 21, 2021
There was a problem hiding this comment.
Thanks @huitseeker, pretty excited about this :)
Just one last comment, otherwise it looks good!
module/errorhandler/erroraware.go
Outdated
| // shutdown the component, | ||
| cancel() | ||
| // wait until it's doneC | ||
| <-done |
There was a problem hiding this comment.
While we are waiting for done, its possible the parentCtx could be cancelled.
In this case, we should abort waiting for shutdown to complete and exit the function. Otherwise, we will still proceed to the handler(err, restart) below even though the parent ctx is cancelled.
I think we just need an additional select statement wrapping this <-done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows an
IrrecoverableErrorHandler, with (separate) integration intocontextandRunComponent+ReadyDoneAware.Possibly superfluous:
Possibly missing: