Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed outdated lingering comment #1311

Merged
merged 4 commits into from Sep 21, 2021
Merged

removed outdated lingering comment #1311

merged 4 commits into from Sep 21, 2021

Conversation

AlexHentschel
Copy link
Member

@AlexHentschel AlexHentschel commented Sep 20, 2021

removed outdates comment; no logic changes

Copy link
Member

@durkmurder durkmurder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Micro approve for micro clean

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2021

Codecov Report

Merging #1311 (26b9633) into master (5ad4831) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1311      +/-   ##
==========================================
- Coverage   54.86%   54.83%   -0.04%     
==========================================
  Files         504      504              
  Lines       31918    31918              
==========================================
- Hits        17512    17502      -10     
- Misses      12031    12039       +8     
- Partials     2375     2377       +2     
Flag Coverage Δ
unittests 54.83% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
engine/consensus/matching/core.go 50.00% <ø> (ø)
...ngine/common/synchronization/finalized_snapshot.go 68.75% <0.00%> (-4.17%) ⬇️
...sus/approvals/assignment_collector_statemachine.go 50.00% <0.00%> (-1.93%) ⬇️
admin/command_runner.go 79.69% <0.00%> (-1.51%) ⬇️
engine/collection/synchronization/engine.go 62.90% <0.00%> (-1.08%) ⬇️
engine/common/synchronization/engine.go 68.78% <0.00%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ad4831...26b9633. Read the comment docs.

@AlexHentschel AlexHentschel merged commit 8e82fb6 into master Sep 21, 2021
@AlexHentschel AlexHentschel deleted the alex/micro_clean branch September 21, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants