Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master to feature consensus voting #1312

Merged

Conversation

zhangchiqing
Copy link
Member

No description provided.

vishalchangrani and others added 30 commits September 3, 2021 14:52
…aked AN; adding option to disable connection pruning
…/5807-collection-sync-engine-refactoring
Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
…:onflow/flow-go into alex/continue-failed-epoch_-_suggestions
@zhangchiqing zhangchiqing force-pushed the merge-master-to-feature-consensus-voting branch 3 times, most recently from c3ffea2 to 459f3c8 Compare September 20, 2021 21:23
@zhangchiqing zhangchiqing force-pushed the merge-master-to-feature-consensus-voting branch from 459f3c8 to 052e1d6 Compare September 20, 2021 21:30
@zhangchiqing zhangchiqing changed the base branch from master to feature/consensus-voting September 20, 2021 21:31
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2021

Codecov Report

Merging #1312 (472ad57) into feature/consensus-voting (7291ffa) will increase coverage by 0.10%.
The diff coverage is 60.65%.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           feature/consensus-voting    #1312      +/-   ##
============================================================
+ Coverage                     54.32%   54.43%   +0.10%     
============================================================
  Files                           512      516       +4     
  Lines                         31950    32186     +236     
============================================================
+ Hits                          17358    17521     +163     
- Misses                        12231    12289      +58     
- Partials                       2361     2376      +15     
Flag Coverage Δ
unittests 54.43% <60.65%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/collection/main.go 2.84% <0.00%> (-0.01%) ⬇️
cmd/consensus/main.go 3.33% <0.00%> (-0.01%) ⬇️
cmd/consensus/notifier.go 0.00% <ø> (ø)
...execution-state-extract/execution_state_extract.go 55.88% <0.00%> (-3.50%) ⬇️
cmd/util/ledger/migrations/balance_reporter.go 0.00% <0.00%> (ø)
...nsensus/approvals/veryfing_assignment_collector.go 59.06% <ø> (ø)
engine/consensus/provider/engine.go 19.29% <ø> (+1.83%) ⬆️
engine/execution/state/state.go 21.98% <0.00%> (+0.55%) ⬆️
fvm/transactionSequenceNum.go 62.50% <ø> (+5.35%) ⬆️
model/bootstrap/node_info.go 33.64% <0.00%> (-4.25%) ⬇️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7291ffa...472ad57. Read the comment docs.

@durkmurder durkmurder merged commit e169fec into feature/consensus-voting Sep 21, 2021
@durkmurder durkmurder deleted the merge-master-to-feature-consensus-voting branch September 21, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet