Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nil dereference #1330

Merged
merged 2 commits into from Sep 22, 2021
Merged

fix nil dereference #1330

merged 2 commits into from Sep 22, 2021

Conversation

synzhu
Copy link
Contributor

@synzhu synzhu commented Sep 22, 2021

No description provided.

admin/command_runner.go Outdated Show resolved Hide resolved
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2021

Codecov Report

Merging #1330 (8dc5771) into master (449a3b5) will decrease coverage by 0.00%.
The diff coverage is 44.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1330      +/-   ##
==========================================
- Coverage   56.22%   56.21%   -0.01%     
==========================================
  Files         501      500       -1     
  Lines       31095    31072      -23     
==========================================
- Hits        17483    17468      -15     
+ Misses      11243    11236       -7     
+ Partials     2369     2368       -1     
Flag Coverage Δ
unittests 56.21% <44.11%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
engine/consensus/matching/core.go 50.00% <ø> (ø)
fvm/blocks.go 58.82% <ø> (ø)
fvm/errors/accounts.go 0.00% <0.00%> (ø)
fvm/errors/base.go 0.00% <0.00%> (ø)
fvm/errors/codes.go 100.00% <ø> (ø)
fvm/errors/execution.go 4.16% <0.00%> (ø)
fvm/handler/accountKey.go 1.30% <ø> (ø)
fvm/handler/metrics.go 65.21% <ø> (ø)
fvm/transactionInvocator.go 73.61% <ø> (ø)
fvm/transactionSequenceNum.go 62.50% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4342cd4...8dc5771. Read the comment docs.

@synzhu synzhu merged commit f3f78f5 into master Sep 22, 2021
@synzhu synzhu deleted the fix-nil-dereference branch September 22, 2021 18:40
@huitseeker
Copy link
Contributor

Hmm, not what I expected, but good fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants