Fixes some build issues when importing flow-go as a dependency
#1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanschalm
requested review from
AlexHentschel and
zhangchiqing
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1333 +/- ##
==========================================
+ Coverage 56.25% 56.29% +0.03%
==========================================
Files 500 500
Lines 31140 31140
==========================================
+ Hits 17518 17529 +11
+ Misses 11253 11242 -11
Partials 2369 2369
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ramtinms
approved these changes
Sep 22, 2021
huitseeker
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
Of course. I wonder if we can test the crypto-version pin desync in CI. @tarakby, would you have any idea?
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Sep 22, 2021
1333: Fixes some build issues when importing `flow-go` as a dependency r=jordanschalm a=jordanschalm This fixes 2 build issues when using `flow-go` as a dependency. 1. The dkg controller factory mock did not have a relic build tag set, but made use of a relic-tagged interface. Solution: Move the interface to a non-relic-tagged file. ``` ../flow-go/module/mock/dkg_controller_factory.go:18:108: undefined: module.DKGController ../flow-go/module/mock/dkg_controller_factory.go:21:9: undefined: module.DKGController ../flow-go/module/mock/dkg_controller_factory.go:22:67: undefined: module.DKGController ../flow-go/module/mock/dkg_controller_factory.go:26:21: undefined: module.DKGController ``` 2. The networking layer imported a function which did not exist in the `crypto` version pinned by `flow-go`. For local development this worked, because we replace with the local `crypto` module, but failed when used as a dependency. ``` ../flow-go/network/p2p/keyutils/keyTranslator.go:169:14: undefined: "github.com/onflow/flow-go/crypto".DecodePublicKeyCompressed ``` Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
|
Canceled. |
|
Hmmm, I just tried to run DPS with this branch as a dependency and got |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 2 build issues when using
flow-goas a dependency.cryptoversion pinned byflow-go. For local development this worked, because we replace with the localcryptomodule, but failed when used as a dependency.