Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Network] improve error logging #1345

Merged
merged 1 commit into from Sep 25, 2021
Merged

[Network] improve error logging #1345

merged 1 commit into from Sep 25, 2021

Conversation

synzhu
Copy link
Contributor

@synzhu synzhu commented Sep 24, 2021

Let's print out the errors encountered so far.

@codecov-commenter
Copy link

Codecov Report

Merging #1345 (9523d59) into master (28a6922) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1345   +/-   ##
=======================================
  Coverage   56.25%   56.25%           
=======================================
  Files         500      500           
  Lines       31162    31162           
=======================================
  Hits        17531    17531           
  Misses      11262    11262           
  Partials     2369     2369           
Flag Coverage Δ
unittests 56.25% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
network/p2p/libp2pNode.go 66.56% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28a6922...9523d59. Read the comment docs.

Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@synzhu
Copy link
Contributor Author

synzhu commented Sep 25, 2021

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 25, 2021

@bors bors bot merged commit d98e739 into master Sep 25, 2021
@bors bors bot deleted the middleware-error-logging branch September 25, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants