Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Execution] add logger to compactor and only log when we do something #1350

Merged
merged 2 commits into from Sep 28, 2021

Conversation

ramtinms
Copy link
Member

Yeah its the time to update this, it makes it harder to look into execution logs :D

Copy link
Contributor

@m4ksio m4ksio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Long overdue simple change

Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

Codecov Report

Merging #1350 (6b590d8) into master (28a6922) will increase coverage by 0.01%.
The diff coverage is 54.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1350      +/-   ##
==========================================
+ Coverage   56.25%   56.27%   +0.01%     
==========================================
  Files         500      502       +2     
  Lines       31162    31208      +46     
==========================================
+ Hits        17531    17562      +31     
- Misses      11262    11273      +11     
- Partials     2369     2373       +4     
Flag Coverage Δ
unittests 56.27% <54.44%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
consensus/config.go 0.00% <0.00%> (ø)
consensus/participant.go 15.95% <0.00%> (ø)
model/flow/role.go 89.36% <ø> (ø)
network/p2p/middleware.go 0.00% <0.00%> (ø)
network/test/testUtil.go 94.90% <ø> (ø)
network/topology/helper.go 82.35% <ø> (-1.86%) ⬇️
network/p2p/libp2pNode.go 65.45% <30.76%> (-1.11%) ⬇️
network/p2p/subscription_filter.go 47.82% <47.82%> (ø)
network/topology/randomizedTopology.go 66.07% <50.00%> (ø)
network/topology/topicBasedTopology.go 71.25% <50.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ba7bcb...6b590d8. Read the comment docs.

@ramtinms ramtinms merged commit 5ca477b into master Sep 28, 2021
@ramtinms ramtinms deleted the ramtin/yeah-those-prints-are-annoying branch September 28, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants