Enable transaction fees on mainnet #1360
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1360 +/- ##
==========================================
- Coverage 56.29% 55.39% -0.91%
==========================================
Files 502 510 +8
Lines 31208 31893 +685
==========================================
+ Hits 17570 17667 +97
- Misses 11263 11852 +589
+ Partials 2375 2374 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cmd/scaffold.go
Outdated
| @@ -671,11 +671,11 @@ func (fnb *FlowNodeBuilder) initFvmOptions() { | |||
| fvm.WithChain(fnb.RootChainID.Chain()), | |||
| fvm.WithBlocks(blockFinder), | |||
| fvm.WithAccountStorageLimit(true), | |||
| fvm.WithTransactionFeesEnabled(true), | |||
There was a problem hiding this comment.
what is the impact of this on localnet and benchnet, it might break loaders, was wondering if we could still filter it by chainID be mainnet,
There was a problem hiding this comment.
I think we've used the loaders on canary before no? And i believe fees are enabled there.
Or did we do extra setup to get the loaders to work for canary?
There was a problem hiding this comment.
you mean the marketplace simulator? I was talking about the default loader that we have for localnet, not sure if we have run it against canary before
There was a problem hiding this comment.
We ran in on both testnet and canary chain before... do the localnet and benchnet have a separate chain id? It might be better to exclude those then.
|
bors merge |
Context
Fees will get turned on on mainnet soon. Currently they are both disabled and set to
0.0. They need to be enabled (with this PR) during a spork. After that they can be set to non0.0when desired.Checks
I verified that:
0.00.0doesn't lead to any unexpected problems (on the emulator)0.0doesn't emit fee deduction events (see the contract)