[Admin] simplify admin server implementation #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synzhu
force-pushed
the
smnzhu/admin-bug
branch
from
891d577
to
543ad5c
Compare
huitseeker
approved these changes
Sep 29, 2021
| if handleErr := handler(ctx, data); handleErr != nil { | ||
| if errors.Is(handleErr, context.Canceled) { | ||
| return status.Error(codes.Canceled, "client canceled") | ||
| } else if errors.Is(handleErr, context.DeadlineExceeded) { |
There was a problem hiding this comment.
we can actually do without the if-elseif-else here since we have a return in each of those clauses
vishalchangrani
approved these changes
Oct 4, 2021
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 4, 2021
1364: [Admin] simplify admin server implementation r=smnzhu a=smnzhu This simplifies the implementation of admin server to remove the `commandQ`, which reduces the surface area for concurrency bugs. gRPC will automatically create a new thread for each admin command, and the rate of admin commands will likely not reach the point where having a queue will be necessary. Co-authored-by: Simon Zhu <simon.zsiyan@gmail.com>
|
Build failed: |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Oct 4, 2021
1364: [Admin] simplify admin server implementation r=smnzhu a=smnzhu This simplifies the implementation of admin server to remove the `commandQ`, which reduces the surface area for concurrency bugs. gRPC will automatically create a new thread for each admin command, and the rate of admin commands will likely not reach the point where having a queue will be necessary. Co-authored-by: Simon Zhu <simon.zsiyan@gmail.com>
|
Build failed: |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 4, 2021
1364: [Admin] simplify admin server implementation r=smnzhu a=smnzhu This simplifies the implementation of admin server to remove the `commandQ`, which reduces the surface area for concurrency bugs. gRPC will automatically create a new thread for each admin command, and the rate of admin commands will likely not reach the point where having a queue will be necessary. Co-authored-by: Simon Zhu <simon.zsiyan@gmail.com>
|
Build failed: |
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the implementation of admin server to remove the
commandQ, which reduces the surface area for concurrency bugs.gRPC will automatically create a new thread for each admin command, and the rate of admin commands will likely not reach the point where having a queue will be necessary.