Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Network] enable subscription filter except ghost node #1365

Merged
merged 1 commit into from Sep 29, 2021

Conversation

synzhu
Copy link
Contributor

@synzhu synzhu commented Sep 27, 2021

Previously, this was disabled on everything except localnet.

Instead, we can probably only disable it for ghost nodes.

@codecov-commenter
Copy link

Codecov Report

Merging #1365 (f6ed91b) into master (28a6922) will increase coverage by 0.01%.
The diff coverage is 52.80%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1365   +/-   ##
=======================================
  Coverage   56.25%   56.26%           
=======================================
  Files         500      502    +2     
  Lines       31162    31208   +46     
=======================================
+ Hits        17531    17560   +29     
- Misses      11262    11275   +13     
- Partials     2369     2373    +4     
Flag Coverage Δ
unittests 56.26% <52.80%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
consensus/config.go 0.00% <0.00%> (ø)
consensus/participant.go 15.95% <0.00%> (ø)
model/flow/role.go 89.36% <ø> (ø)
network/p2p/middleware.go 0.00% <0.00%> (ø)
network/test/testUtil.go 94.90% <ø> (ø)
network/topology/helper.go 82.35% <ø> (-1.86%) ⬇️
network/p2p/libp2pNode.go 65.45% <28.57%> (-1.11%) ⬇️
network/p2p/subscription_filter.go 47.82% <47.82%> (ø)
network/topology/randomizedTopology.go 66.07% <50.00%> (ø)
network/topology/topicBasedTopology.go 71.25% <50.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ba7bcb...f6ed91b. Read the comment docs.

Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1210 for context.

@smnzhu thanks!

@synzhu
Copy link
Contributor Author

synzhu commented Sep 29, 2021

bors merge

1 similar comment
@synzhu
Copy link
Contributor Author

synzhu commented Sep 29, 2021

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 29, 2021

Already running a review

@bors
Copy link
Contributor

bors bot commented Sep 29, 2021

@bors bors bot merged commit 2e6b861 into master Sep 29, 2021
@bors bors bot deleted the smnzhu/subscription-filter branch September 29, 2021 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants