[Bootstrap] Extracted rootblock and updated finalize
#1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Added encoding and writing to disk encoded root block and votes
…ementing reading/writing of DKG and root block
There was a problem hiding this comment.
Thanks Yurii - looks good, had 2 main comments:
- We are losing DKG index information when converting between types. This will cause verification to fail.
- I added a suggestion to avoid needing to load a private key to aggregate the QC. This is not strictly a blocker, but I think it's worth removing the unneeded flag and logic.
cmd/bootstrap/run/qc.go
Outdated
|
|
||
| // GenerateQCSignerParticipantData generates participant data for creating QC. | ||
| // Caller needs to pass dkg participants that will be taking part in building QC. | ||
| func GenerateQCSignerParticipantData(internalNodes []bootstrap.NodeInfo, dkgParticipant dkg.DKGParticipantPriv, dkgData inmem.EncodableDKG) (*ParticipantData, error) { |
There was a problem hiding this comment.
As mentioned in the other comment, we don't actually need a private key to generate a QC from existing votes.
I wrote up a function that should do the trick to generate a signer/validator which can be used, without needing to load any private data (which ultimately isn't used anyway):
func createAggregator(participantData *ParticipantData) (hotstuff.Validator, hotstuff.SignerVerifier, error) {
identities := participantData.Identities()
var (
unusedLocalNodeID = flow.ZeroID
unusedModuleLocal module.Local = nil
unusedPrivateKey crypto.PrivateKey = nil
)
// create consensus committee's state
committee, err := committees.NewStaticCommittee(identities, unusedLocalNodeID, participantData.Lookup, participantData.GroupKey)
if err != nil {
return nil, nil, err
}
merger := signature.NewCombiner(encodable.ConsensusVoteSigLen, encodable.RandomBeaconSigLen)
stakingSigner := signature.NewAggregationProvider(encoding.ConsensusVoteTag, unusedModuleLocal)
beaconVerifier := signature.NewThresholdVerifier(encoding.RandomBeaconTag)
beaconSigner := signature.NewThresholdProvider(encoding.RandomBeaconTag, unusedPrivateKey)
beaconStore := signature.NewSingleSignerStore(beaconSigner)
signer := verification.NewCombinedSigner(committee, stakingSigner, beaconVerifier, merger, beaconStore, flow.ZeroID)
validator := validator.New(committee, new(mocks.ForksReader), signer)
return validator, signer, nil
}
…w/flow-go into yurii/5891-update-finalize
added 4 commits
September 28, 2021 13:54
…re _reading_ the infos and not generating them
Codecov Report
@@ Coverage Diff @@
## master #1371 +/- ##
==========================================
+ Coverage 56.36% 56.44% +0.07%
==========================================
Files 504 505 +1
Lines 31210 31332 +122
==========================================
+ Hits 17593 17684 +91
- Misses 11247 11271 +24
- Partials 2370 2377 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
synzhu
reviewed
Sep 29, 2021
jordanschalm
added a commit
that referenced
this pull request
Sep 29, 2021
Porting #1371 to `v0.21_consensus_test`
jordanschalm
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dapperlabs/flow-go#5889
dapperlabs/flow-go#5891
Context
This PR implements
rootblockcommand for bootstrap utility and updatesfinalize.As result of
rootblockwe output DKG info and root block + votes into separate files.finalizewill consume public DKG data, root block and votes to construct QC and initialize collection clusters.