[v0.22] Add Secrets Database #1381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* provide Init functions to initialize a DB with a particular type * add methods to assert a DB is a particular type which can be used in constructors of storage modules which require a particular type
require --secretsdir flag
jordanschalm
requested review from
AlexHentschel,
vishalchangrani and
zhangchiqing
as code owners
jordanschalm
requested review from
ramtinms
and removed request for
vishalchangrani and
AlexHentschel
zhangchiqing
approved these changes
Sep 29, 2021
|
Closing this, as we will be merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #1309 to
v0.22for inclusion in Canary spork.