Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.21] Backport 1376 #1396

Merged
merged 7 commits into from
Sep 30, 2021
Merged

[0.21] Backport 1376 #1396

merged 7 commits into from
Sep 30, 2021

Conversation

m4ksio
Copy link
Contributor

@m4ksio m4ksio commented Sep 30, 2021

Backports
#1376 and #1338

@m4ksio
Extract Accounts into an interface for easier testing
54ad07e 
(cherry picked from commit 31bc5a4)
@m4ksio
Encode user input in error
3a7767a 
(cherry picked from commit b2e6eff)
@m4ksio
Review comments
059b00a 
(cherry picked from commit c7689b0)
@m4ksio
lint
eb2c4e7 
(cherry picked from commit 17a2d89)
@m4ksio
Clarify godoc
49d9978 
Add extra check for error type in a test

(cherry picked from commit 96244c9)
@m4ksio
lint
0ed26a4 
(cherry picked from commit 01b62a8)
@m4ksio
Copy link
Contributor Author

m4ksio commented Sep 30, 2021

bors try

bors bot added a commit that referenced this pull request Sep 30, 2021
@bors
Try #1396:
3188664
@bors
Copy link
Contributor

bors bot commented Sep 30, 2021

try

Build failed:

@m4ksio
Copy link
Contributor Author

m4ksio commented Sep 30, 2021

bors try

bors bot added a commit that referenced this pull request Sep 30, 2021
@bors
Try #1396:
c236955
@bors
Copy link
Contributor

bors bot commented Sep 30, 2021

try

Build succeeded:

@vishalchangrani vishalchangrani merged commit 46f635f into v0.21 Sep 30, 2021
@vishalchangrani vishalchangrani deleted the m4ksio/backport-1376 branch September 30, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalchangrani vishalchangrani vishalchangrani approved these changes

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik is a code owner

@ramtinms ramtinms Awaiting requested review from ramtinms ramtinms is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m4ksio @vishalchangrani