Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blockID logging #1408

Merged
merged 3 commits into from Oct 6, 2021
Merged

Add blockID logging #1408

merged 3 commits into from Oct 6, 2021

Conversation

m4ksio
Copy link
Contributor

@m4ksio m4ksio commented Oct 1, 2021

rename reference block for clarity

@m4ksio
add blockID logging
ce96369 
rename reference block for clarity
@m4ksio m4ksio requested a review from ramtinms as a code owner October 1, 2021 20:14
@m4ksio m4ksio changed the title Ddd blockID logging Add blockID logging Oct 1, 2021
huitseeker
huitseeker approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@m4ksio
Copy link
Contributor Author

m4ksio commented Oct 4, 2021

bors merge

bors bot added a commit that referenced this pull request Oct 4, 2021
@bors @m4ksio @zhangchiqing
Merge #1408
11be6a4 
1408: Add blockID logging r=m4ksio a=m4ksio

rename reference block for clarity

Co-authored-by: Maks Pawlak <120831+m4ksio@users.noreply.github.com>
Co-authored-by: Leo Zhang <zhangchiqing@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1408 (4c255ff) into master (28862e1) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1408      +/-   ##
==========================================
- Coverage   55.33%   55.30%   -0.03%     
==========================================
  Files         516      516              
  Lines       32167    32168       +1     
==========================================
- Hits        17798    17791       -7     
- Misses      11979    11989      +10     
+ Partials     2390     2388       -2
Flag Coverage Δ
unittests 55.30% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
engine/execution/computation/computer/computer.go 84.40% <100.00%> (+0.07%) ⬆️
...sus/approvals/assignment_collector_statemachine.go 42.30% <0.00%> (-9.62%) ⬇️
consensus/hotstuff/event_loop.go 54.66% <0.00%> (+2.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28862e1...4c255ff. Read the comment docs.

@m4ksio m4ksio merged commit c5fc8ac into master Oct 6, 2021
@m4ksio m4ksio deleted the m4ksio/better-collection-logging branch October 6, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker huitseeker approved these changes

@zhangchiqing zhangchiqing zhangchiqing approved these changes

@ramtinms ramtinms Awaiting requested review from ramtinms ramtinms is a code owner

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@m4ksio @codecov-commenter @huitseeker @zhangchiqing @janezpodhostnik