Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs links #1420

Merged
merged 2 commits into from Oct 7, 2021
Merged

Fix docs links #1420

merged 2 commits into from Oct 7, 2021

Conversation

mjudeikis
Copy link
Contributor

Few links redirecting to nothing

Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, much appreciated!

@@ -1,6 +1,6 @@
# Access Node

The access node provides a single point of contact to interact with the Flow network. It implements the [Access API](https://github.com/onflow/flow/blob/master/docs/access-api-spec.md)
The access node provides a single point of contact to interact with the Flow network. It implements the [Access API](https://github.com/onflow/flow/blob/master/docs/content/access-api.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the links!

It might be even better to link to the rendered page instead of the source, here and for the other links below

Suggested change
The access node provides a single point of contact to interact with the Flow network. It implements the [Access API](https://github.com/onflow/flow/blob/master/docs/content/access-api.md)
The access node provides a single point of contact to interact with the Flow network. It implements the [Access API](https://docs.onflow.org/access-api/)

@codecov-commenter
Copy link

Codecov Report

Merging #1420 (55410a7) into master (9d0c789) will decrease coverage by 0.11%.
The diff coverage is 50.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1420      +/-   ##
==========================================
- Coverage   55.41%   55.29%   -0.12%     
==========================================
  Files         512      516       +4     
  Lines       31942    32168     +226     
==========================================
+ Hits        17700    17788      +88     
- Misses      11862    11993     +131     
- Partials     2380     2387       +7     
Flag Coverage Δ
unittests 55.29% <50.58%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
engine/consensus/ingestion/engine.go 45.63% <ø> (+0.12%) ⬆️
module/dkg/controller_factory.go 0.00% <0.00%> (ø)
module/dkg/broker.go 58.55% <46.80%> (-7.31%) ⬇️
module/epochs/qc_voter.go 59.67% <52.17%> (+1.34%) ⬆️
engine/collection/pusher/engine.go 65.38% <100.00%> (-0.66%) ⬇️
...ngine/common/synchronization/finalized_snapshot.go 68.75% <0.00%> (-4.17%) ⬇️
network/p2p/dns/resolver.go 98.76% <0.00%> (-1.24%) ⬇️
engine/collection/synchronization/engine.go 62.90% <0.00%> (-1.08%) ⬇️
admin/command_runner.go 77.58% <0.00%> (-0.94%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95cc399...55410a7. Read the comment docs.

@huitseeker
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 7, 2021

@bors bors bot merged commit d8dd306 into onflow:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants