Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify address conversion #1422

Merged
merged 2 commits into from Oct 23, 2021
Merged

Conversation

turbolent
Copy link
Member

There is no need to convert from a Cadence address, an 8-byte array, to a short byte slice (leading zeros removed), then convert back to a Flow address, again an 8-byte array. Simply convert directly between the two arrays address types

@Kay-Zee
Copy link
Member

Kay-Zee commented Oct 23, 2021

bors merge

@codecov-commenter
Copy link

Codecov Report

Merging #1422 (7eba824) into master (aa41a3b) will decrease coverage by 0.00%.
The diff coverage is 77.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1422      +/-   ##
==========================================
- Coverage   55.18%   55.17%   -0.01%     
==========================================
  Files         521      521              
  Lines       32522    32522              
==========================================
- Hits        17946    17945       -1     
- Misses      12166    12167       +1     
  Partials     2410     2410              
Flag Coverage Δ
unittests 55.17% <77.27%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
fvm/scriptEnv.go 40.30% <62.50%> (ø)
fvm/transactionEnv.go 48.81% <80.00%> (ø)
fvm/account.go 83.33% <100.00%> (ø)
fvm/transactionInvocator.go 73.61% <100.00%> (ø)
fvm/transactionStorageLimiter.go 85.71% <100.00%> (ø)
module/component/component.go 37.86% <0.00%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb51334...7eba824. Read the comment docs.

@bors
Copy link
Contributor

bors bot commented Oct 23, 2021

@bors bors bot merged commit 0915166 into master Oct 23, 2021
@bors bors bot deleted the bastian/simplify-address-conversion branch October 23, 2021 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants