remove redundant key generation code #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kc1116
requested review from
AlexHentschel,
m4ksio,
ramtinms,
vishalchangrani,
yhassanzadeh13 and
zhangchiqing
as code owners
kc1116
requested review from
huitseeker and
jordanschalm
and removed request for
m4ksio,
zhangchiqing,
ramtinms and
yhassanzadeh13
jordanschalm
approved these changes
Oct 8, 2021
utils/unittest/keys.go
Outdated
| sk, err := crypto.GeneratePrivateKey(crypto.BLSBLS12381, seed) | ||
| return sk, err | ||
| func StakingKey() crypto.PrivateKey { | ||
| return BLS12381Key() | ||
| } | ||
|
|
||
| func StakingKeys(n int) ([]crypto.PrivateKey, error) { |
There was a problem hiding this comment.
We can remove the error return here as well
integration/tests/epochs/suite.go
Outdated
Comment on lines
235
to
236
| stakingAccountKey = unittest.ECDSAP256Key() | ||
| networkingKey = unittest.ECDSAP256Key() |
There was a problem hiding this comment.
Suggested change
| stakingAccountKey = unittest.ECDSAP256Key() | |
| networkingKey = unittest.ECDSAP256Key() | |
| stakingAccountKey = unittest.ECDSAP256Key() | |
| networkingKey = unittest.NetworkingKey() |
Naming suggestion: operatorAccountKey rather than stakingAccountKey (for the reasons we've discussed of the confusion between stakingKey and stakingAccountKey)
huitseeker
reviewed
Oct 8, 2021
There was a problem hiding this comment.
Thanks for tackling the late comments:
- ECDSAKey, BLSKey can be replaced everywhere with
PrivateKeyFixture(crypto.ECDSAP256, crypto.KeyGenSeedMinLenECDSAP256),PrivateKeyFixture(crypto.BLSBLS12381, crypto.KeyGenSeedMinLenBLSBLS12381). I don't need we need the level of indirection - we manipulate a ton of stakingKey, networkingKey, variables, etc. A way to manage the confusion is to make the function names more clear about what's going on in fixtures:
RandomStakingPrivKey,RandomNetworkingPrivKey...
|
|
bors merge |
Codecov Report
@@ Coverage Diff @@
## master #1469 +/- ##
=======================================
Coverage 55.11% 55.12%
=======================================
Files 517 517
Lines 32334 32330 -4
=======================================
+ Hits 17821 17822 +1
+ Misses 12121 12114 -7
- Partials 2392 2394 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to remove some redundant key generation code flagged in a separate PR .