-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport HotStuff view metric fixes from v0.22-mainnet
#1477
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
fd710c9
set no-op hotstuff view fun for non-sn nodes
jordanschalm 4b0271f
Update ping labels
Kay-Zee 9055136
Merge branch 'master' into jordan/backport-hotstuff-view-metrics-fixes
jordanschalm a78aa39
only consensus ndoes report new metrics
zhangchiqing 30592e0
add context and error return to non-SN view metric provider
jordanschalm eb38fbf
Merge branch 'jordan/backport-hotstuff-view-metrics-fixes' of github.…
jordanschalm d3be0ed
Merge branch 'master' into jordan/backport-hotstuff-view-metrics-fixes
zhangchiqing 2a554df
Merge branch 'master' into jordan/backport-hotstuff-view-metrics-fixes
jordanschalm File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jordanschalm for fixing this.
I removed the label
Role
, because only consensus nodes will report this methods, not even collection nodes.I've tested with localnet, and it worked.
I tested last time as well, I thought it worked, but actually I didn't run the localnet long enough to catch the bug.