Fixing broken links in access node docs #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/access/README.md
Outdated
| @@ -40,10 +40,10 @@ At a high level it does the following: | |||
| ## Processes | |||
|
|
|||
| ### Transaction Lifecycle | |||
| 1. Transactions are received by the access node via the [SendTransaction API call](https://onflow.org/docs/access-api#sendtransaction). | |||
| 1. Transactions are received by the access node via the [SendTransaction API call](https://docs.onflow.org/access-api/#transactions). | |||
There was a problem hiding this comment.
The more detailed anchor links (https://docs.onflow.org/access-api/#sendtransaction) actually work fine me
There was a problem hiding this comment.
You are right, I tried this and it failed but I must have messed up some other part of the URL. Will send an update shortly.
j1010001
force-pushed
the
access-node-docs-fix
branch
from
ef3bce9
to
1a6c6a9
Compare
jordanschalm
approved these changes
Oct 12, 2021
Kay-Zee
approved these changes
Oct 13, 2021
Codecov Report
@@ Coverage Diff @@
## master #1481 +/- ##
==========================================
+ Coverage 55.12% 55.14% +0.01%
==========================================
Files 517 520 +3
Lines 32330 32413 +83
==========================================
+ Hits 17823 17873 +50
- Misses 12116 12143 +27
- Partials 2391 2397 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some anchors in the original links (SendTransaction, GetTransaction, GetTransactionResult) can only be replaced by pointing to high-level transactions section - there are no method-specific anchors in the new docs.