Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky Test Monitor - moving result processing to main repo #1500

Merged
merged 16 commits into from Oct 22, 2021

Conversation

gomisha
Copy link
Contributor

@gomisha gomisha commented Oct 20, 2021

splitting up for #1495 - this PR just is for the json processing code for the Flaky Test Monitor

original json processing code from https://github.com/onflow/flakiness-summary - that repo will be discontinued as explained in #1495

@synzhu synzhu requested a review from Kay-Zee October 20, 2021 16:31
Copy link
Contributor

@synzhu synzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2021

Codecov Report

Merging #1500 (de3821f) into master (11299bb) will increase coverage by 0.02%.
The diff coverage is 67.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1500      +/-   ##
==========================================
+ Coverage   55.09%   55.11%   +0.02%     
==========================================
  Files         520      521       +1     
  Lines       32418    32514      +96     
==========================================
+ Hits        17860    17920      +60     
- Misses      12161    12187      +26     
- Partials     2397     2407      +10     
Flag Coverage Δ
unittests 55.11% <67.70%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tools/flaky_test_monitor/process_results.go 67.70% <67.70%> (ø)
module/synchronization/status.go 41.17% <0.00%> (-17.65%) ⬇️
module/synchronization/core.go 76.21% <0.00%> (-7.93%) ⬇️
engine/collection/synchronization/engine.go 63.97% <0.00%> (+1.07%) ⬆️
admin/command_runner.go 78.94% <0.00%> (+1.75%) ⬆️
...sus/approvals/assignment_collector_statemachine.go 42.30% <0.00%> (+1.92%) ⬆️
module/component/component.go 40.77% <0.00%> (+2.91%) ⬆️
...ngine/common/synchronization/finalized_snapshot.go 72.91% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11299bb...de3821f. Read the comment docs.

flaky_test_monitor/process_results_test.go Outdated Show resolved Hide resolved
flaky_test_monitor/process_results.go Outdated Show resolved Hide resolved
flaky_test_monitor/process_results.go Outdated Show resolved Hide resolved
flaky_test_monitor/process_results_test.go Outdated Show resolved Hide resolved
flaky_test_monitor/process_results_test.go Outdated Show resolved Hide resolved
flaky_test_monitor/process_results_test.go Outdated Show resolved Hide resolved
flaky_test_monitor/process_results_test.go Outdated Show resolved Hide resolved
@gomisha gomisha merged commit 38702f7 into master Oct 22, 2021
@gomisha gomisha deleted the misha/flaky-test-detection-json-parser branch October 22, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants