Kan/clean up secondary result index #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Kay-Zee
commented
Oct 22, 2021
Kay-Zee
commented
- Fix the secondary index memory leak
- Add test for confirming secondary index also stays at "limit"
- Fix Incorporated results tests that weren't working as intended
synzhu
approved these changes
Oct 22, 2021
| func TestApprovalsLRUCacheSecondaryIndexPurge(t *testing.T) { | ||
| numElements := uint(10) | ||
| cache := NewApprovalsLRUCache(numElements) | ||
| approvals := make([]*flow.ResultApproval, 2*numElements) |
There was a problem hiding this comment.
It seems this approvals field isn't really necessary? We don't actually do anything with the approvals we store inside.
There was a problem hiding this comment.
Maybe you actually meant to add a check?
| for i := range results { | ||
| result := unittest.IncorporatedResult.Fixture() | ||
| results[i] = result | ||
| require.True(t, cache.Put(result.ID(), result)) | ||
| require.Equal(t, result, cache.Get(result.ID())) | ||
| } | ||
| require.ElementsMatch(t, results, cache.All()) | ||
| require.Equal(t, int(numElements), len(cache.All())) |
There was a problem hiding this comment.
same comments here as above.
Codecov Report
@@ Coverage Diff @@
## master #1515 +/- ##
==========================================
+ Coverage 55.09% 55.15% +0.05%
==========================================
Files 521 521
Lines 32514 32515 +1
==========================================
+ Hits 17914 17933 +19
+ Misses 12192 12173 -19
- Partials 2408 2409 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Simon Zhu <simon.zsiyan@gmail.com>
zhangchiqing
approved these changes
Oct 22, 2021
zhangchiqing
added a commit
that referenced
this pull request
Oct 22, 2021
* Remove from secondary index * Add tests for caches * add concurrency test * Apply suggestions from code review Co-authored-by: Simon Zhu <simon.zsiyan@gmail.com> Co-authored-by: Leo Zhang (zhangchiqing) <zhangchiqing@gmail.com> Co-authored-by: Simon Zhu <simon.zsiyan@gmail.com>
zhangchiqing
added a commit
that referenced
this pull request
Oct 22, 2021
* fix potential mem-leak from hotstuff (#1514) * Kan/clean up secondary result index (#1515) * Remove from secondary index * Add tests for caches * add concurrency test * Apply suggestions from code review Co-authored-by: Simon Zhu <simon.zsiyan@gmail.com> Co-authored-by: Leo Zhang (zhangchiqing) <zhangchiqing@gmail.com> Co-authored-by: Simon Zhu <simon.zsiyan@gmail.com> * disable cache metrics Co-authored-by: Kan Zhang <kan@axiomzen.co> Co-authored-by: Simon Zhu <simon.zsiyan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.