Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log vote's signer and block when vote is invalid #1982

Merged
merged 4 commits into from Feb 15, 2022
Merged

Conversation

zhangchiqing
Copy link
Member

Adding logs so that when we receive invalid vote, we know the signer from the error log

@codecov-commenter
Copy link

Codecov Report

Merging #1982 (f9fc19a) into master (6569650) will decrease coverage by 0.01%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1982      +/-   ##
==========================================
- Coverage   57.58%   57.57%   -0.02%     
==========================================
  Files         631      631              
  Lines       36124    36129       +5     
==========================================
- Hits        20802    20800       -2     
- Misses      12703    12711       +8     
+ Partials     2619     2618       -1     
Flag Coverage Δ
unittests 57.57% <44.44%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/bootstrap/run/qc.go 40.27% <0.00%> (-2.37%) ⬇️
cmd/bootstrap/cmd/finalize.go 65.37% <100.00%> (+0.11%) ⬆️
...sus/approvals/assignment_collector_statemachine.go 42.30% <0.00%> (-4.81%) ⬇️
engine/collection/synchronization/engine.go 67.93% <0.00%> (ø)
consensus/hotstuff/eventloop/event_loop.go 70.73% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6569650...f9fc19a. Read the comment docs.

@zhangchiqing
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 15, 2022

Build succeeded:

@bors bors bot merged commit e3915c6 into master Feb 15, 2022
@bors bors bot deleted the leo/logging-votes branch February 15, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants