Khalil/1662 epoch test suite updates #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- avoid pausing access node used for client connections when running the access node suite
integration/tests/epochs/epoch.go
Outdated
Comment on lines
212
to
219
| if role == flow.RoleAccess { | ||
| containerToReplace = s.getContainerToReplace(role, "access_2") | ||
| require.NotNil(s.T(), containerToReplace) | ||
| } else { | ||
| // grab the first container of this node role type, this is the container we will replace | ||
| containerToReplace = s.getContainerToReplace(role, "") | ||
| require.NotNil(s.T(), containerToReplace) | ||
| } |
There was a problem hiding this comment.
Would it be more clear to have two functions:
Suggested change
| if role == flow.RoleAccess { | |
| containerToReplace = s.getContainerToReplace(role, "access_2") | |
| require.NotNil(s.T(), containerToReplace) | |
| } else { | |
| // grab the first container of this node role type, this is the container we will replace | |
| containerToReplace = s.getContainerToReplace(role, "") | |
| require.NotNil(s.T(), containerToReplace) | |
| } | |
| if role == flow.RoleAccess { | |
| containerToReplace = s.getContainerToReplaceByName("access_2") | |
| require.NotNil(s.T(), containerToReplace) | |
| } else { | |
| // grab the first container of this node role type, this is the container we will replace | |
| containerToReplace = s.getContainerToReplaceByRole(role) | |
| require.NotNil(s.T(), containerToReplace) | |
| } |
jordanschalm
approved these changes
Feb 23, 2022
zhangchiqing
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some small updates to the epoch integration test suite: