New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor epochs related contract deployments, use blueprints pattern #2057
Conversation
…ootstrap procedure Use the blueprints pattern
FVM Benchstat comparisonThis branch with compared with the base branch onflow:master commit a3a7ad8 The command Bench tests were run a total of 7 times on each branch. Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we move over registerNodeTransaction
as well? Otherwise looks great 🧹🧹
Codecov Report
@@ Coverage Diff @@
## master #2057 +/- ##
==========================================
+ Coverage 57.25% 57.32% +0.07%
==========================================
Files 633 633
Lines 36836 36745 -91
==========================================
- Hits 21089 21065 -24
+ Misses 13095 13026 -69
- Partials 2652 2654 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
"github.com/onflow/flow-go/model/bootstrap" | ||
|
||
"github.com/onflow/flow-go/module/epochs" | ||
|
||
"github.com/onflow/flow-go/model/flow" | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is is possible to use templates from the core contracts repo and SDK here instead of hard-coding the transaction text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like most of the hardcoded transactions either don't have a corresponding tx in templates or they are different slightly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that could mean it might be worth adding some of them, but I guess that make sense
bors merge |
Canceled. |
bors merge |
2057: Refactor epochs related contract deployments, use blueprints pattern r=kc1116 a=kc1116 This PR updates the transactions related to epochs in the fvm bootstrap procedure, it moves these transactions to the blueprints package. Co-authored-by: Khalil Claybon <khalil.claybon@dapperlabs.com>
Build failed: |
This PR updates the transactions related to epochs in the fvm bootstrap procedure, it moves these transactions to the blueprints package.