Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Serializable Snapshots #209

Merged
merged 235 commits into from
Mar 16, 2021
Merged

Conversation

jordanschalm
Copy link
Member

@jordanschalm jordanschalm commented Dec 4, 2020

Epic: https://github.com/dapperlabs/flow-go/issues/4829

This combines the following PRs:

there are cyclical dependencies otherwise
test all phases from epochs 1-2 and encode/decode cycle
These were effectively already using similar memory-backed
implementations, this removes the duplication
Copy link
Member

@zhangchiqing zhangchiqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Jordan! 🎉

image

Copy link
Member

@durkmurder durkmurder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through, LGTM.

@jordanschalm jordanschalm merged commit 8785755 into master Mar 16, 2021
@jordanschalm jordanschalm deleted the feature/serializable-snapshots branch March 16, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants