New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FVM] refactor computation and memory metering #2129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
How come the base for this branch is cadence-issue-1127
?
FVM Benchstat comparisonThis branch with compared with the base branch onflow:master commit 6c08a14 The command Bench tests were run a total of 7 times on each branch. Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for also already starting on integration / preparing for the memory metering 👍
Codecov Report
@@ Coverage Diff @@
## master #2129 +/- ##
==========================================
- Coverage 57.52% 57.47% -0.05%
==========================================
Files 637 637
Lines 37211 37261 +50
==========================================
+ Hits 21405 21416 +11
- Misses 13126 13163 +37
- Partials 2680 2682 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This pr