[Admin] GetIdentity command #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2191 +/- ##
==========================================
- Coverage 57.56% 57.48% -0.09%
==========================================
Files 642 643 +1
Lines 38117 38154 +37
==========================================
- Hits 21943 21933 -10
- Misses 13382 13430 +48
+ Partials 2792 2791 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
simonhf
reviewed
Mar 24, 2022
| @@ -1113,6 +1113,8 @@ func (fnb *FlowNodeBuilder) RegisterDefaultAdminCommands() { | |||
| return storageCommands.NewReadResultsCommand(config.State, config.Storage.Results) | |||
| }).AdminCommand("read-seals", func(config *NodeConfig) commands.AdminCommand { | |||
| return storageCommands.NewReadSealsCommand(config.State, config.Storage.Seals, config.Storage.Index) | |||
| }).AdminCommand("get-identity", func(config *NodeConfig) commands.AdminCommand { | |||
| return common.NewGetIdentityCommand(config.IdentityProvider) | |||
There was a problem hiding this comment.
It would be great to add example curl command lines to the README.md [1] file like the other commands :-)
[1] https://github.com/onflow/flow-go/tree/cd1449feabdaa2be1ebe1c5ccb51eb96f1649b80/admin
simonhf
approved these changes
Mar 24, 2022
zhangchiqing
approved these changes
Mar 28, 2022
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new command to get identity info by flow ID or libp2p peer ID.