[Execution] Not broadcast sealed ER #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangchiqing
requested review from
Kay-Zee and
ramtinms
and removed request for
psiemens
zhangchiqing
force-pushed
the
leo/not-broadcast-sealed-er
branch
from
452cbb3
to
ce0b7a7
Compare
zhangchiqing
requested review from
AlexHentschel,
jordanschalm,
tarakby and
yhassanzadeh13
as code owners
ramtinms
reviewed
Dec 15, 2020
Comment on lines
+561
to
+562
| // if the receipt is for a sealed block, then no need to broadcast it. | ||
| lastSealed, err := e.state.Sealed().Head() |
There was a problem hiding this comment.
does this consider finalization for the block that includes the seal?
There was a problem hiding this comment.
yes, sealed means it's sealed AND finalized.
ramtinms
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the network metrics, it seems the execution halt problem is not because of missing collection, the root cause is that the execution node is still broadcasting those old results, which causes the verification node to respond back with a chunk data request. And the network queue quickly filled up by these requests, and grew to a point that no more collection can be forwarded to the ingestion engine, and case the execution to halt.
This PR changes to not broadcast result for sealed blocks, since the block has already been sealed, there is no value in broadcasting it.