Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Node Restart #276

Merged
merged 4 commits into from Jan 12, 2021
Merged

Fix Node Restart #276

merged 4 commits into from Jan 12, 2021

Conversation

zhangchiqing
Copy link
Member

@zhangchiqing zhangchiqing commented Jan 12, 2021

  • Fixed a bug that causes the node unable to restart
  • Added test case to verify a bootstrapped protocol state can be opened again (see TestBootstrapOpen)

@@ -198,7 +198,7 @@ func OpenState(
if err != nil {
return nil, nil, fmt.Errorf("failed retrieve root block's epoch status: %w", err)
}
epochSetup, err := setups.ByID(epochStatus.CurrentEpoch.CommitID)
epochSetup, err := setups.ByID(epochStatus.CurrentEpoch.SetupID)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this caused the node unable to restart

@zhangchiqing zhangchiqing marked this pull request as ready for review January 12, 2021 01:06
Copy link
Member

@jordanschalm jordanschalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this 🎣

Copy link
Member

@Kay-Zee Kay-Zee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beauty!

@zhangchiqing zhangchiqing merged commit 7e98cf8 into master Jan 12, 2021
@zhangchiqing zhangchiqing deleted the leo/fix-bootstrap-open branch January 12, 2021 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants