[Execution] state migration clean up #3192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramtinms
commented
Sep 7, 2022
Comment on lines
-91
to
-92
| storageUsedUpdateMigration.Migrate, | ||
| mgr.PruneMigration, |
There was a problem hiding this comment.
We don't need these two if there is no other migration applied
There was a problem hiding this comment.
Do we no longer need the PruneMigration If I remember correctly we always ran that.
Codecov Report
@@ Coverage Diff @@
## master #3192 +/- ##
==========================================
- Coverage 53.87% 51.74% -2.14%
==========================================
Files 743 615 -128
Lines 68520 58126 -10394
==========================================
- Hits 36917 30077 -6840
+ Misses 28557 25509 -3048
+ Partials 3046 2540 -506
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
zhangchiqing
approved these changes
Sep 10, 2022
janezpodhostnik
approved these changes
Sep 13, 2022
Comment on lines
-91
to
-92
| storageUsedUpdateMigration.Migrate, | ||
| mgr.PruneMigration, |
There was a problem hiding this comment.
Do we no longer need the PruneMigration If I remember correctly we always ran that.
|
bors merge |
bors
bot
deleted the
ramtin/cleanup-migrations-after-spork-to-mainnet19
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove the migration codes that has already been a applied on all networks.