[FVM] Remove old quick fixes

[janezpodhostnik]

Both of these were already properly fixed either in the FVM or in cadence.

The reason I am removing them now is because the fuzz tests test exactly what these quick fixes were for: a scenario where the node crashes but shouldn't, because of reaching the limits at a bad location in the code.

I ran the fuzzer for an entire day after removing this.

[codecov-commenter]

Codecov Report

Merging #3219 (0212dd5) into master (248a79d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3219      +/-   ##
==========================================
+ Coverage   53.89%   53.91%   +0.01%     
==========================================
  Files         743      743              
  Lines       68407    68391      -16     
==========================================
+ Hits        36869    36870       +1     
+ Misses      28487    28472      -15     
+ Partials     3051     3049       -2     

Flag	Coverage Δ
unittests	53.91% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
fvm/transaction.go	89.79% <ø> (+11.82%)	⬆️
fvm/transactionInvoker.go	68.82% <100.00%> (-1.07%)	⬇️
...e/orchestrator/mock_corruptible_conduit_factory.go	80.59% <0.00%> (-2.99%)	⬇️
engine/access/ingestion/engine.go	59.55% <0.00%> (-0.19%)	⬇️
fvm/handler/contract.go	72.68% <0.00%> (ø)
consensus/hotstuff/eventloop/event_loop.go	74.82% <0.00%> (ø)
network/p2p/dns/resolver.go	96.36% <0.00%> (+4.84%)	⬆️
insecure/orchestrator/corrupted_connection.go	82.35% <0.00%> (+7.84%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[github-actions]

FVM Benchstat comparison

This branch with compared with the base branch onflow:master commit 248a79d

The command (for i in {1..10}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

	old.txt	new.txt
	time/op		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/get_signer_vault-2	36.6ms ± 5%	37.6ms ± 5%	+2.64%	(p=0.028 n=10+9)
RuntimeTransaction/get_signer_address-2	28.9ms ± 5%	29.7ms ± 4%	+2.61%	(p=0.023 n=10+10)
RuntimeTransaction/convert_int_to_string-2	30.8ms ±13%	31.0ms ±14%	~	(p=0.853 n=10+10)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	31.9ms ± 7%	31.7ms ±10%	~	(p=0.447 n=9+10)
RuntimeTransaction/get_public_account-2	32.6ms ± 3%	32.8ms ± 6%	~	(p=0.971 n=10+10)
RuntimeTransaction/get_account_and_get_balance-2	313ms ± 3%	312ms ± 4%	~	(p=0.931 n=9+9)
RuntimeTransaction/get_account_and_get_available_balance-2	291ms ± 4%	295ms ± 4%	~	(p=0.053 n=10+9)
RuntimeTransaction/get_account_and_get_storage_used-2	34.2ms ± 8%	34.1ms ± 5%	~	(p=0.720 n=10+9)
RuntimeTransaction/get_account_and_get_storage_capacity-2	254ms ± 1%	258ms ± 3%	~	(p=0.353 n=10+10)
RuntimeTransaction/get_signer_receiver-2	47.0ms ± 6%	46.8ms ± 6%	~	(p=0.684 n=10+10)
RuntimeTransaction/transfer_tokens-2	213ms ± 2%	215ms ± 5%	~	(p=0.905 n=9+10)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	37.2ms ± 6%	36.0ms ± 7%	~	(p=0.095 n=10+9)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	80.7ms ± 5%	79.4ms ± 5%	~	(p=0.218 n=10+10)
RuntimeTransaction/create_new_account-2	848ms ± 1%	854ms ± 2%	~	(p=0.408 n=8+10)
RuntimeTransaction/call_empty_contract_function-2	32.4ms ± 5%	31.7ms ± 3%	~	(p=0.203 n=10+8)
RuntimeTransaction/emit_event-2	47.4ms ± 5%	47.0ms ± 3%	~	(p=0.604 n=9+10)
RuntimeTransaction/borrow_array_from_storage-2	134ms ± 4%	134ms ± 4%	~	(p=0.436 n=10+10)
RuntimeTransaction/copy_array_from_storage-2	140ms ± 6%	140ms ± 3%	~	(p=0.912 n=10+10)
RuntimeNFTBatchTransfer-2	114ms ± 3%	114ms ± 2%	~	(p=0.666 n=9+9)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	4.99s ± 2%	4.94s ± 3%	~	(p=0.089 n=10+10)
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2	29.3ms ±11%	27.1ms ±11%	−7.54%	(p=0.009 n=10+10)
	computation		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2	202 ± 0%	202 ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	502 ± 0%	502 ± 0%	~	(all equal)
RuntimeTransaction/get_signer_address-2	302 ± 0%	302 ± 0%	~	(all equal)
RuntimeTransaction/get_public_account-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_balance-2	1.00k ± 0%	1.00k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_available_balance-2	2.60k ± 0%	2.60k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_used-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_capacity-2	1.30k ± 0%	1.30k ± 0%	~	(all equal)
RuntimeTransaction/get_signer_vault-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/get_signer_receiver-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/transfer_tokens-2	3.50k ± 0%	3.50k ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/create_new_account-2	202 ± 0%	202 ± 0%	~	(all equal)
RuntimeTransaction/call_empty_contract_function-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/emit_event-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/borrow_array_from_storage-2	2.60k ± 0%	2.60k ± 0%	~	(all equal)
RuntimeTransaction/copy_array_from_storage-2	2.60k ± 0%	2.60k ± 0%	~	(all equal)
	interactions		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2	44.4k ± 0%	44.4k ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string-2	44.4k ± 0%	44.4k ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	44.4k ± 0%	44.4k ± 0%	~	(all equal)
RuntimeTransaction/get_signer_address-2	44.4k ± 0%	44.4k ± 0%	~	(all equal)
RuntimeTransaction/get_public_account-2	44.4k ± 0%	44.4k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_balance-2	16.8M ± 0%	16.8M ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_available_balance-2	5.28M ± 0%	5.28M ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_used-2	48.0k ± 0%	48.0k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_capacity-2	5.27M ± 0%	5.27M ± 0%	~	(all equal)
RuntimeTransaction/get_signer_vault-2	44.7k ± 0%	44.7k ± 0%	~	(all equal)
RuntimeTransaction/get_signer_receiver-2	45.0k ± 0%	45.0k ± 0%	~	(all equal)
RuntimeTransaction/transfer_tokens-2	45.8k ± 0%	45.8k ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	44.8k ± 0%	44.8k ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	49.7k ± 0%	49.7k ± 0%	~	(all equal)
RuntimeTransaction/create_new_account-2	8.53M ± 0%	8.53M ± 0%	~	(all equal)
RuntimeTransaction/call_empty_contract_function-2	44.6k ± 0%	44.6k ± 0%	~	(all equal)
RuntimeTransaction/emit_event-2	44.6k ± 0%	44.6k ± 0%	~	(all equal)
RuntimeTransaction/borrow_array_from_storage-2	49.8k ± 0%	49.8k ± 0%	~	(all equal)
RuntimeTransaction/copy_array_from_storage-2	49.8k ± 0%	49.8k ± 0%	~	(all equal)
	alloc/op		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/get_signer_address-2	36.9MB ± 5%	38.8MB ± 8%	+5.19%	(p=0.003 n=10+10)
RuntimeTransaction/reference_tx-2	37.6MB ± 9%	36.2MB ± 7%	~	(p=0.063 n=10+10)
RuntimeTransaction/convert_int_to_string-2	37.6MB ± 6%	37.5MB ± 5%	~	(p=0.912 n=10+10)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	37.5MB ± 8%	37.3MB ± 9%	~	(p=0.579 n=10+10)
RuntimeTransaction/get_public_account-2	38.9MB ± 4%	38.7MB ± 4%	~	(p=0.631 n=10+10)
RuntimeTransaction/get_account_and_get_balance-2	141MB ± 2%	141MB ± 2%	~	(p=0.853 n=10+10)
RuntimeTransaction/get_account_and_get_available_balance-2	123MB ± 3%	124MB ± 3%	~	(p=0.481 n=10+10)
RuntimeTransaction/get_account_and_get_storage_used-2	38.5MB ± 5%	38.3MB ± 2%	~	(p=0.364 n=10+7)
RuntimeTransaction/get_account_and_get_storage_capacity-2	117MB ± 2%	118MB ± 2%	~	(p=0.353 n=10+10)
RuntimeTransaction/get_signer_vault-2	38.6MB ± 6%	39.2MB ± 6%	~	(p=0.481 n=10+10)
RuntimeTransaction/get_signer_receiver-2	42.0MB ± 7%	41.6MB ± 5%	~	(p=0.684 n=10+10)
RuntimeTransaction/transfer_tokens-2	91.0MB ± 3%	90.6MB ± 2%	~	(p=0.796 n=10+10)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	39.1MB ± 5%	38.6MB ±10%	~	(p=0.436 n=10+10)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	57.9MB ± 4%	57.2MB ± 4%	~	(p=0.353 n=10+10)
RuntimeTransaction/create_new_account-2	209MB ± 2%	209MB ± 0%	~	(p=0.958 n=10+6)
RuntimeTransaction/call_empty_contract_function-2	38.5MB ± 7%	38.0MB ± 4%	~	(p=0.393 n=10+10)
RuntimeTransaction/emit_event-2	43.3MB ± 5%	43.1MB ± 4%	~	(p=0.842 n=9+10)
RuntimeTransaction/borrow_array_from_storage-2	68.9MB ± 6%	68.8MB ± 6%	~	(p=0.579 n=10+10)
RuntimeTransaction/copy_array_from_storage-2	83.8MB ± 3%	84.7MB ± 2%	~	(p=0.356 n=9+10)
RuntimeNFTBatchTransfer-2	57.3MB ± 2%	57.6MB ± 4%	~	(p=0.661 n=9+10)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	1.32GB ± 1%	1.33GB ± 1%	~	(p=0.247 n=10+10)
	allocs/op		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/get_account_and_get_storage_used-2	139k ± 0%	139k ± 0%	+0.01%	(p=0.003 n=10+10)
RuntimeTransaction/get_account_and_get_balance-2	1.71M ± 0%	1.71M ± 0%	+0.00%	(p=0.031 n=9+9)
RuntimeTransaction/reference_tx-2	89.5k ± 0%	89.5k ± 0%	~	(p=0.060 n=10+10)
RuntimeTransaction/convert_int_to_string-2	104k ± 0%	104k ± 0%	~	(p=0.400 n=10+10)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	118k ± 0%	118k ± 0%	~	(p=0.493 n=10+10)
RuntimeTransaction/get_signer_address-2	94.7k ± 0%	94.7k ± 0%	~	(p=0.059 n=10+10)
RuntimeTransaction/get_public_account-2	118k ± 0%	118k ± 0%	~	(p=0.565 n=10+10)
RuntimeTransaction/get_account_and_get_available_balance-2	1.58M ± 0%	1.58M ± 0%	~	(p=0.342 n=10+10)
RuntimeTransaction/get_account_and_get_storage_capacity-2	1.42M ± 0%	1.42M ± 0%	~	(p=0.278 n=10+9)
RuntimeTransaction/get_signer_vault-2	142k ± 0%	142k ± 0%	~	(p=0.239 n=10+10)
RuntimeTransaction/get_signer_receiver-2	222k ± 0%	222k ± 0%	~	(p=0.516 n=10+10)
RuntimeTransaction/transfer_tokens-2	971k ± 0%	971k ± 0%	~	(p=0.225 n=10+10)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	242k ± 0%	242k ± 0%	~	(p=0.566 n=10+10)
RuntimeTransaction/create_new_account-2	2.80M ± 0%	2.80M ± 0%	~	(p=0.811 n=10+10)
RuntimeTransaction/call_empty_contract_function-2	106k ± 0%	106k ± 0%	~	(p=0.368 n=8+10)
RuntimeTransaction/emit_event-2	151k ± 0%	151k ± 0%	~	(p=0.184 n=10+10)
RuntimeTransaction/borrow_array_from_storage-2	379k ± 0%	379k ± 0%	~	(p=0.345 n=10+9)
RuntimeTransaction/copy_array_from_storage-2	335k ± 0%	335k ± 0%	~	(p=0.754 n=10+10)
RuntimeNFTBatchTransfer-2	304k ± 0%	304k ± 0%	~	(p=0.459 n=9+10)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	21.0M ± 0%	21.0M ± 0%	~	(p=0.165 n=10+10)
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	140k ± 0%	140k ± 0%	−0.01%	(p=0.037 n=10+9)
	us/tx		delta
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	2.44k ± 2%	2.41k ± 3%	~	(p=0.086 n=10+10)

[janezpodhostnik]

bors merge

[bors]

Build succeeded:

• Integration Tests (make -C integration access-tests)
• Integration Tests (make -C integration bft-tests)
• Integration Tests (make -C integration collection-tests)
• Integration Tests (make -C integration consensus-tests)
• Integration Tests (make -C integration epochs-tests)
• Integration Tests (make -C integration execution-tests)
• Integration Tests (make -C integration ghost-tests)
• Integration Tests (make -C integration mvp-tests)
• Integration Tests (make -C integration network-tests)
• Integration Tests (make -C integration verification-tests)
• Lint (./)
• Lint (./crypto/)
• Lint (./integration/)
• Unit Tests (access)
• Unit Tests (admin)
• Unit Tests (cmd)
• Unit Tests (consensus)
• Unit Tests (engine)
• Unit Tests (fvm)
• Unit Tests (ledger)
• Unit Tests (module)
• Unit Tests (network)
• Unit Tests (others)
• Unit Tests (utils)