Khalil/6474 Gossipsub RPC control message Spam protection: GRAFT & PRUNE #4103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Public flow-go master sync
workflow_dispatch: only on master-private branch
…into master-private
Please approve this workflow for security code scanning. Please let me know if you have any questions!
Kan/add sec scanning
Public flow-go master sync
target-branch: "master-public"
added all directories with go.mod
…r-branches Kan/run ci against all master branches
Public flow-go master sync
master* branch name match
revert back to `master` - test if CI not run
foo2
revert back to master*
…ter-branches run ci against all master branches - `master-public`
Public flow-go master sync
Public flow-go master sync
Public flow-go master sync
Public flow-go master sync
Public flow-go master sync
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
…flow-go into khalil/6474-graft-prune-spam
Public flow-go master sync
Public flow-go master sync
…alil/6474-graft-prune-spam
…into private-to-public-sync
Khalil/6474 Gossupsub RPC control message Spam protection: GRAFT & PRUNE
…into private-to-public-sync
gomisha
changed the title
gomisha
changed the title
peterargue
approved these changes
Mar 27, 2023
yhassanzadeh13
approved these changes
Mar 27, 2023
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds spam protection for gossipsub RPC control messages (GRAFT & PRUNE). It adds a new ControlMsgValidationInspector which is a gossipsub RPC inspector that performs the following validation on control messages for each of the control types (GRAFT & PRUNE). These protections are important due to the fact that RPC messages are processed synchronously by libp2p and a malicious actor could exhaust the nodes resources or degrade the nodes network performance by spamming costly control messages.
I suggest you start your review in the inspector package which contains all the new inspector logic and the control message validation inspector gossip spammer tests.
ref: https://github.com/dapperlabs/flow-go/pull/6555
author: @kc1116