Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Add grpc streaming metrics #4540

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Conversation

peterargue
Copy link
Contributor

@peterargue peterargue commented Jul 5, 2023

Currently, the state streaming API only records unary grpc metrics. This PR adds support for collecting streaming grpc metrics as well.

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023

Codecov Report

Merging #4540 (7b304d2) into master (12f898b) will increase coverage by 0.35%.
The diff coverage is 63.40%.

@@            Coverage Diff             @@
##           master    #4540      +/-   ##
==========================================
+ Coverage   54.09%   54.45%   +0.35%     
==========================================
  Files         563      911     +348     
  Lines       56220    85076   +28856     
==========================================
+ Hits        30414    46329   +15915     
- Misses      23459    35171   +11712     
- Partials     2347     3576    +1229     
Flag Coverage Δ
unittests 54.45% <63.40%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
admin/commands/storage/read_range_blocks.go 0.00% <0.00%> (ø)
...dmin/commands/storage/read_range_cluster_blocks.go 0.00% <0.00%> (ø)
cmd/execution_builder.go 0.00% <0.00%> (ø)
cmd/execution_config.go 0.00% <0.00%> (ø)
cmd/node_builder.go 93.87% <ø> (-2.07%) ⬇️
cmd/scaffold.go 14.76% <0.00%> (+0.26%) ⬆️
cmd/util/ledger/reporters/export_reporter.go 0.00% <ø> (ø)
cmd/utils.go 20.58% <ø> (+3.51%) ⬆️
cmd/verification_builder.go 0.00% <0.00%> (ø)
consensus/aggregators.go 0.00% <0.00%> (ø)
... and 88 more

... and 333 files with indirect coverage changes

@peterargue
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Jul 6, 2023
4540: [Access] Add grpc streaming metrics r=peterargue a=peterargue

Currently, the state streaming API only records unary grpc metrics. This PR adds support for collecting streaming grpc metrics as well.

Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Jul 6, 2023

Build failed:

@peterargue peterargue merged commit 2528190 into master Jul 7, 2023
33 checks passed
@peterargue peterargue deleted the petera/add-streaming-metrics branch July 7, 2023 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants