Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Networking] Improves p2p node logging #4898

Merged
merged 10 commits into from
Nov 14, 2023

Conversation

yhassanzadeh13
Copy link
Contributor

This PR improves the logging of the libp2p node by pre-pending the local peer id (libp2p identifier) to the logger. This helps peer_id to flow_id translation in production.

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (5d07b31) 56.19% compared to head (4eeb13c) 57.55%.

Files Patch % Lines
network/p2p/p2pbuilder/libp2pNodeBuilder.go 0.00% 7 Missing ⚠️
network/validator/target_validator.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4898      +/-   ##
==========================================
+ Coverage   56.19%   57.55%   +1.35%     
==========================================
  Files         969      793     -176     
  Lines       90269    75520   -14749     
==========================================
- Hits        50725    43462    -7263     
+ Misses      35770    28777    -6993     
+ Partials     3774     3281     -493     
Flag Coverage Δ
unittests 57.55% <10.00%> (+1.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yhassanzadeh13 yhassanzadeh13 added this pull request to the merge queue Oct 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2023
@yhassanzadeh13 yhassanzadeh13 added this pull request to the merge queue Oct 31, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 31, 2023
@yhassanzadeh13 yhassanzadeh13 added this pull request to the merge queue Oct 31, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 31, 2023
@yhassanzadeh13 yhassanzadeh13 added this pull request to the merge queue Nov 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2023
@yhassanzadeh13 yhassanzadeh13 added this pull request to the merge queue Nov 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2023
@yhassanzadeh13 yhassanzadeh13 added this pull request to the merge queue Nov 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2023
@yhassanzadeh13 yhassanzadeh13 added this pull request to the merge queue Nov 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2023
@yhassanzadeh13 yhassanzadeh13 added this pull request to the merge queue Nov 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2023
@yhassanzadeh13 yhassanzadeh13 added this pull request to the merge queue Nov 14, 2023
Merged via the queue into master with commit fa7a065 Nov 14, 2023
54 checks passed
@yhassanzadeh13 yhassanzadeh13 deleted the yahya/improve-libp2p-logging branch November 14, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants