Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ledger migration fixes #49

Merged
merged 13 commits into from
Oct 8, 2020
Merged

Ledger migration fixes #49

merged 13 commits into from
Oct 8, 2020

Conversation

m4ksio
Copy link
Contributor

@m4ksio m4ksio commented Oct 7, 2020

No description provided.

@m4ksio m4ksio requested a review from psiemens as a code owner October 7, 2020 03:50
@m4ksio m4ksio mentioned this pull request Oct 7, 2020
Closed
ramtinms
ramtinms reviewed Oct 7, 2020
View reviewed changes
Copy link
Member

@ramtinms ramtinms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, if you don't mind just merge my PR to this branch as well

zhangchiqing
zhangchiqing approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@zhangchiqing zhangchiqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Some minor suggestions.

cmd/bootstrap/run/execution_state.go Show resolved Hide resolved
cmd/util/cmd/execution-state-extract/cmd.go Outdated Show resolved Hide resolved
cmd/util/cmd/recalculate-mappings/cmd.go Outdated Show resolved Hide resolved
@m4ksio m4ksio merged commit 3fe6699 into master Oct 8, 2020
@m4ksio m4ksio deleted the m4ksio/ledger-migration-fixes branch October 8, 2020 18:31
@Kay-Zee Kay-Zee added the Bugfix label Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramtinms ramtinms ramtinms left review comments

@zhangchiqing zhangchiqing zhangchiqing approved these changes

@psiemens psiemens Awaiting requested review from psiemens

@Kay-Zee Kay-Zee Awaiting requested review from Kay-Zee

Assignees
No one assigned
Labels
Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@m4ksio @zhangchiqing @ramtinms @Kay-Zee