Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FLIP 204: Update cruisectl.BlockTimeController to use TargetEndTime, TargetDuration #5023

Merged
merged 130 commits into from
Nov 24, 2023
Merged

FLIP 204: Update cruisectl.BlockTimeController to use TargetEndTime, TargetDuration #5023

merged 130 commits into from
Nov 24, 2023

Conversation

jordanschalm
Copy link
Member

@jordanschalm jordanschalm commented Nov 15, 2023 •
edited

Addresses #4946

@gomisha
unit tests, integration tests using buildjet-4vcpu runner
bc5e7ef
@gomisha
listTargetPackages() returns map of CI runners
fb69048
@gomisha
test for custom runners
291e71d
@gomisha
generateTestMatrix() stores CI runner
e7a7f7e
@gomisha
more testing with custom CI runners
371e4b3
@gomisha
CI test - 2 unit tests running buildjet runners
00117a4
@gomisha
increase engine unit tests to 8 vCPUs
6a25c05
@gomisha
resource manager full load test (8 vCPUs)
0a3854b
@gomisha
network/test tests unquarantined, increased runners
983e488
@gomisha
Merge branch 'master' into misha/6894-buildjet-ci-test
0b422d5
@gomisha
increased to 16 vCPUs
6048198
@gomisha
increased engine tests to 16 vCPUs
eb81e79
@gomisha
insecure module uses buildjet 4 vcpu runner
d496e7f
@gomisha
bft framework integration test using buildjet
d320b6b
@gomisha
engine tests split up to 6 jobs with default runners
620d6a1
@gomisha
added back all integration tests
daeac5f
@gomisha
upgraded runners for some integration tests, engine/execution
98c5197
@gomisha
dummy commit to kick off CI
1259067
@gomisha
split up TestScriptExecutionAndGetAccounts into 3 tests
959bf17
@gomisha
updated runners for Epoch Cohort2, Access Integration Tests
027513c
@gomisha
AN integration tests split up into 3 cohorts (skip unit, other integr…
e6a5ef3 
…ation tests)
@gomisha
docker build using GitHub cache
10c9edd
@gomisha
remove saving Docker image locally
c589487
@gomisha
cache v3, saving local tar before caching, 8vcpu
5998a0d
@gomisha
add 11 docker images to docker-images.tar, 16 vcpu
9f86a31
@gomisha
docker save multiline fix; skip localnet-test
ba1b00f
@gomisha
docker build increase to 32 vcpu
544b877
@gomisha
buildjet cache instead of GitHub cache
99a9b9e
@gomisha
lint fix
0e4d303
@gomisha
activate more integration tests with default runners, using cached Do…
94192f6 
…cker
@jordanschalm jordanschalm changed the title FLIP 204: Update cruisectl.BlockTimeController to use TargetEndTime FLIP 204: Update cruisectl.BlockTimeController to use TargetEndTime, TargetDuration Nov 20, 2023
jordanschalm and others added 6 commits November 20, 2023 11:05
@jordanschalm
Merge branch 'jordan/4945-target-duration' into jordan/4946-cruise-ct…
23578b6 
…l-target-end-time
@jordanschalm
track target duration in block time ctl
fd98175
@jordanschalm
remove transition_time
65742dd
@jordanschalm
update tests
5b1fcb6
@jordanschalm
fix last 2 tests
de48577 
- add helper functions for concisely converting between various
  time/duration types.
- use ns-level precision in view measurement, primarily so that we can
  verify this implementation is consistent with the Python simulation.
  For real-world, second-level precision is likely fine.
@jordanschalm
Update consensus/hotstuff/cruisectl/block_time_controller.go
b1cf665 
Co-authored-by: Alexander Hentschel <alex.hentschel@axiomzen.co>
@jordanschalm jordanschalm requested review from durkmurder and AlexHentschel and removed request for ramtinms, gomisha and yhassanzadeh13 November 20, 2023 18:53
@jordanschalm jordanschalm mentioned this pull request Nov 20, 2023
Merged
AlexHentschel
AlexHentschel approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@AlexHentschel AlexHentschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clean work.

consensus/hotstuff/cruisectl/block_time_controller.go Outdated Show resolved Hide resolved
consensus/hotstuff/cruisectl/block_time_controller.go Outdated Show resolved Hide resolved
consensus/hotstuff/cruisectl/block_time_controller.go Outdated Show resolved Hide resolved
consensus/hotstuff/cruisectl/block_time_controller.go Outdated Show resolved Hide resolved
consensus/hotstuff/cruisectl/block_time_controller.go Outdated Show resolved Hide resolved
consensus/hotstuff/cruisectl/config.go Outdated Show resolved Hide resolved
state/protocol/inmem/encodable.go Outdated Show resolved Hide resolved
@jordanschalm
Copy link
Member Author

@durkmurder The dependent PR has been merged, and this is ready for another review now 🙏

durkmurder
durkmurder approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@durkmurder durkmurder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✈️

@jordanschalm jordanschalm merged commit de721aa into feature/flip-204-epoch-target-end-time Nov 24, 2023
54 checks passed
@jordanschalm jordanschalm deleted the jordan/4946-cruise-ctl-target-end-time branch November 24, 2023 20:32
This was referenced Nov 27, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durkmurder durkmurder durkmurder approved these changes

@AlexHentschel AlexHentschel AlexHentschel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jordanschalm @codecov-commenter @durkmurder @AlexHentschel @gomisha