Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM] Bridged account balance function #5098

Merged
merged 18 commits into from
Dec 11, 2023
Merged

Conversation

sideninja
Copy link
Member

Closes: #5096

This PR adds a function to the bridged account to query the balance. Currently, there is no way to query the account balance and this exposes querying balance on the bridged account through the EVMInternal.

… gregor/evm/account-get-balance

# Conflicts:
#	fvm/fvm_bench_test.go
#	fvm/fvm_test.go
#	fvm/transactionInvoker.go
#	go.mod
#	integration/go.mod
#	integration/go.sum
Base automatically changed from gregor/evm/cadence-event to master December 4, 2023 13:16
# Conflicts:
#	fvm/fvm_bench_test.go
#	fvm/fvm_test.go
#	fvm/transactionInvoker.go
#	integration/go.mod
#	integration/go.sum
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fef6b06) 56.27% compared to head (074d623) 49.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5098      +/-   ##
==========================================
- Coverage   56.27%   49.11%   -7.16%     
==========================================
  Files         977      178     -799     
  Lines       91770    14871   -76899     
==========================================
- Hits        51644     7304   -44340     
+ Misses      36300     7064   -29236     
+ Partials     3826      503    -3323     
Flag Coverage Δ
unittests 49.11% <ø> (-7.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sideninja sideninja added this pull request to the merge queue Dec 11, 2023
Merged via the queue into master with commit a8b45d6 Dec 11, 2023
53 checks passed
@sideninja sideninja deleted the gregor/evm/account-get-balance branch December 11, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EVM] Add balance to the account stdlib
4 participants