Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix retrieving receipts #528

Merged
merged 4 commits into from
Mar 16, 2021
Merged

fix retrieving receipts #528

merged 4 commits into from
Mar 16, 2021

Conversation

zhangchiqing
Copy link
Member

Problem

execution nodes can't return executed receipts to consensus nodes

Cause

  • We now deprecated the PersistExecutionReceipt and PersistExecutionResult , as well as PersistStateInteractions . And replaced with one call: PersistExecutionState.
  • We also solved the receipts index issue, and updated the deprecated PersistExecutionReceipt method, which no longer being used

This PR fixes it by storing my receipts after results have been persisted

@zhangchiqing zhangchiqing requested review from AlexHentschel and durkmurder and removed request for psiemens March 16, 2021 17:12
AlexHentschel
AlexHentschel approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@AlexHentschel AlexHentschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick fix @zhangchiqing

durkmurder
durkmurder approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@durkmurder durkmurder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangchiqing zhangchiqing merged commit d72cc92 into master Mar 16, 2021
@zhangchiqing zhangchiqing deleted the leo/fix-retrieve-receipts branch March 16, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durkmurder durkmurder durkmurder approved these changes

@AlexHentschel AlexHentschel AlexHentschel approved these changes

@m4ksio m4ksio Awaiting requested review from m4ksio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhangchiqing @durkmurder @AlexHentschel